Fix manual_inspect to consider mutability
#13609
Conversation
rustbot
added
the
S-waiting-on-review
clippy_utils/src/lib.rs
Outdated
| /// Assignment. | ||
| Assign(usize), | ||
| /// Assignment with an operator. | ||
| AssignOp(BinOpKind, usize), |
There was a problem hiding this comment.
No need to capture this. The lint already checks if the binding in the closure is mutable so x = something would fail to compile.
There was a problem hiding this comment.
The lint already checks if the binding in the closure is mutable so
x = somethingwould fail to compile.
Do you mean this line?
&& let PatKind::Binding(BindingMode(ByRef::No, Mutability::Not), arg_id, _, None) = param.pat.kindThis checks the mut pattern, right. So Assign is indeed not needed for this lint, but given that it's a function in clippy_utils, I'd like to make it take all cases into account as much as possible. And AssignOp is still needed for something like x += y.
There was a problem hiding this comment.
x += y also wouldn't compile. Once you fix use_mutability there will be no uses of these variants left (use_node and expr_use_ctxt shouldn't be used there).
clippy_utils/src/lib.rs
Outdated
| pub fn use_mutability(&self, cx: &LateContext<'tcx>) -> Mutability { | ||
| match self.use_node(cx) { | ||
| ExprUseNode::FieldAccess(parent, _) => { | ||
| let parent = cx.tcx.hir().expect_expr(parent); | ||
| expr_use_ctxt(cx, parent).use_mutability(cx) | ||
| }, | ||
| ExprUseNode::AssignOp(_, 0) | ExprUseNode::Assign(0) => Mutability::Mut, | ||
| ExprUseNode::AddrOf(_, mutbl) => mutbl, | ||
| ExprUseNode::FnArg(_, _) | ExprUseNode::MethodArg(_, _, _) => { | ||
| let child_expr = cx.tcx.hir().expect_expr(self.child_id); | ||
| let ty = cx.typeck_results().expr_ty_adjusted(child_expr); | ||
| ty.ref_mutability().unwrap_or(Mutability::Not) | ||
| }, | ||
| _ => Mutability::Not, | ||
| } | ||
| } |
There was a problem hiding this comment.
Using expr_use_ctxt here is wrong since it allows moves to occur. Just use parent_iter.
You'll need to handle mutable borrow or deref adjustments, mutable borrows, mutable derefs, mutable indexing, and assignments. For indexing and derefs you can't tell at the expression so you have to keep walking up the tree. For adjustments, don't go by the resulting type, but walk the adjustments themselves. Mutable auto-deref doesn't always result in a reference after all adjustments take place.
There was a problem hiding this comment.
Oh, thanks for pointing those out, I'll check it out.
Mutable auto-deref doesn't always result in a reference after all adjustments take place.
Would you mind explaining it further? Under what circumstances would adjustments not work? So that I can write a test case to make sure of that.
There was a problem hiding this comment.
Field accesses through a pointer don't. e.g. x.y where x is a reference will have have a deref adjustment, but not a borrow adjustment.
clippy_utils/src/lib.rs
Outdated
| ExprKind::AddrOf(kind, mutbl, _) => ExprUseNode::AddrOf(kind, mutbl), | ||
| ExprKind::Assign(lhs, rhs, _) => { | ||
| debug_assert!(lhs.hir_id == self.child_id || rhs.hir_id == self.child_id); | ||
| #[allow(clippy::bool_to_int_with_if)] |
There was a problem hiding this comment.
NIT:
| #[allow(clippy::bool_to_int_with_if)] | |
| #[expect(clippy::bool_to_int_with_if)] |
Is there a reason why you rather expect this lint over taking the suggestion?
|
☔ The latest upstream changes (presumably #13639) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hey @SpriteOvO , this is a ping from triage, since there hasn't been any activity in some time. Are you still planning to continue this implementation? If you have any questions, you're always welcome to ask them in this PR or on Zulip. @rustbot author |
rustbot
added
S-waiting-on-author
|
Sorry about that, I'm a bit busy recently, and I will probably continue this PR starting next week. |
SpriteOvO
force-pushed
the
fix-manual_inspect
branch
from
d45f4ef to
ff22ee9
Compare
|
Oh, waittt.. I'm still working on it now, that force-push was just a rebasing. |
|
xD, sorry, I only checked the changed file and that one looked good, so I got a bit too trigger happy. Thank you for catching this in time! |
SpriteOvO
force-pushed
the
fix-manual_inspect
branch
from
ff22ee9 to
9615e76
Compare
|
@xFrednet It's fine, I also very sorry for the super delay updates (just finished it), I have pushed the latest changes based on the reviews. Could you and @Jarcho review it again? I have changed to use |
SpriteOvO
force-pushed
the
fix-manual_inspect
branch
from
9615e76 to
0595b19
Compare
Fixes #13185.
In this PR, we fix the false positives. I left some FIXME cases, it would be nice if they could be supported in the future.
changelog: [
manual_inspect]: Fix to consider mutability