fix: Fix ItemScope not recording glob imports
#19016
Merged
+234
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
ItemScope not recording glob importsItemScope not recording glob imports
Veykril
force-pushed
the
push-moqnsytyrupu
branch
from
796a0d5 to
5e09069
Compare
This caused us other code to incorrectly assume in dealing with a declaration when in fact it was dealing with a glob imported definition
Veykril
force-pushed
the
push-moqnsytyrupu
branch
from
5e09069 to
3b88a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused us other code to incorrectly assume in dealing with a declaration when in fact it was dealing with a glob imported definition. This can cause hangs with certain setups that involve glob imports and local item block modules (not sure on the exact setup needed), it also means we do a lot more work in some cases (or even wrong work).