Properly record meaningful imports as re-exports in symbol index #18967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
A bit noisy of a commit history as there were a couple of bugs I encountered. |
Veykril
force-pushed
the
push-pwonkmwqmmol
branch
from
44b2da1 to
a06606c
Compare
|
This seems to have some unintended side effects, symbol search now hangs for me in the salsa repo 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I somehow didn't realize that #18699 never fixed what it was supposed to fix. Probably because I accidentally expect updated the test.
The gist of this PR is that we now record all imports that have an explicit visibility set (or that exist in the crate-root), treating them as if they are re-exports (opposed to only treating rename imports as such). This in turn fixes the completion issue as the relevant import is now recorded.
I do fear this might have an impact on flyimport completion times as we have a lot more symbols to go through now, will investigate that before merging.