Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "object safe" to "dyn compatible" #1666

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Oct 28, 2024

Supersedes #1512: In line with T-lang's latest resolution.

Part of rust-lang/rust#130852.

r? @traviscross

@fmease
Copy link
Member Author

fmease commented Oct 28, 2024

std/keyword.dyn.html:13: broken link fragment #object-safety pointing to reference/items/traits.html
cargo/print.html:9654: broken link fragment #object-safety pointing to reference/items/traits.html
cargo/reference/semver.html:1354: broken link fragment #object-safety pointing to reference/items/traits.html

Alright, so am I meant to update the links in std & cargo before this PR gets merged? Apparently, linkchecker doesn't like the JS URL rewrites. If I were to update std & cargo first, wouldn't this mean that these links would actually be broken until the next r-l/rust books sync (*)? I've intentionally left all #object-safe links intact everywhere (library, compiler, rustdoc) to avoid this exact scenario.

(*) Or actually until the sync hits stable because std (..) links to the stable version of the Reference, not the nightly one and not channel-dependently?

This is a temporary workaround since the linkchecker is not aware of
javascript fragment redirects.
This is not a rule, but an editorial aside.
Generally the reference should not be keeping track of the historical
evolution of features.
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I pushed some small changes, in particular to fix the linkchecker. When there are other books that link to something, we have to temporarily include an HTML tag to hold the identifier. I will eventually try to get the other books updated.

@ehuss ehuss added this pull request to the merge queue Oct 30, 2024
Merged via the queue into rust-lang:master with commit 85c4a7a Oct 30, 2024
5 checks passed
@fmease fmease deleted the mv-obj-safe-dyn-compat branch October 30, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants