Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkgconf instead of pkg-config for brew builds #173

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+5 −3
Open

Use pkgconf instead of pkg-config for brew builds #173

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19cdc2d
Use `pkgconf` instead of `pkg-config` for brew builds
chenrui333 Dec 19, 2024
3c2aa27
remove iOS target from pkg-config installation instructions as Homebr…
chenrui333 Dec 20, 2024
15a342f
add pr feedback
chenrui333 Jan 2, 2025
90743f8
support linuxbrew
chenrui333 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,12 @@ impl fmt::Display for Error {
io::ErrorKind::NotFound => {
let crate_name =
std::env::var("CARGO_PKG_NAME").unwrap_or_else(|_| "sys".to_owned());
let instructions = if cfg!(target_os = "macos") || cfg!(target_os = "ios") {
"Try `brew install pkg-config` if you have Homebrew.\n"
let instructions = if cfg!(target_os = "macos") {
"Try `brew install pkgconf` if you have Homebrew.\n"
} else if cfg!(target_os = "ios") {
"" // iOS cross-compilation requires a custom setup, no easy fix
} else if cfg!(unix) {
"Try `apt install pkg-config`, or `yum install pkg-config`,\n\
"Try `apt install pkg-config`, or `yum install pkg-config`, or `brew install pkgconf`\n\
or `pkg install pkg-config`, or `apk add pkgconfig` \
depending on your distribution.\n"
} else {
Expand Down
Loading