Rename generic type parameter in Subtyping chapter #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`T` was used to refer both to the generic type parameter of the function used as an example, and to the type that this generic type parameter would be a reference to. To make things clearer, the generic type parameter is renamed to `R`, since it is intended to be a reference in the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like several issues (#124, #262, #305, #339) have pointed before, the chapter “Subtyping and Variance” can easily become confusing. I have experienced that as well, and I have noticed that this was partially caused by
Tused both in&'a Tand as the&'a Titself in&mut &'a T(thus written&mut T).To make things clearer, this PR renames the generic type parameter of the function
R, since it is intended to be a reference in the examples.&'a Tstays unchanged, butRis used when&'a Titself is intended; for instance, the more generic variant of&mut &'a Tis thus&mut R.I have also slightly changed some explanations to clarify them and take into account this new naming.