New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get/set thread name shims return errors for invalid handles #4004

Open

YohDeadfall wants to merge 5 commits into rust-lang:master from YohDeadfall:thread-name-ice-fix

+135 −56

Contributor

YohDeadfall commented Oct 30, 2024

Fixes #3965.

YohDeadfall added 5 commits

October 31, 2024 02:30


          Get/set thread name shims return errors for invalid handles

bf0a2d9


          Clippy

e0b3761


          Doc fix

04c3985


          Fixed macOS logic for a zero sized buffer

2f72e30


          Fixed an ICE happening for invalid thread identifiers

27d58c3

Contributor Author

YohDeadfall commented Oct 31, 2024

So, I feel satisfied now. There was an issue with the thread identifier conversion causing ICEs, but that happens no more.

@rustbot review

rustbot added the S-waiting-on-review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review