Clear eval_libc errors from unix shims
#3984
Merged
+28
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahmbright
commented
Oct 21, 2024
RalfJung
reviewed
Oct 22, 2024
noahmbright
commented
Oct 24, 2024
Note that this does not trigger a notification, so it is easy to be missed. Please do this instead: |
RalfJung
reviewed
Oct 25, 2024
|
@rustbot author |
rustbot
added
S-waiting-on-author
noahmbright
force-pushed
the
unix_shims
branch
from
6676a0c
to
53b4f85
Compare
|
Reverted that change in sync.rs and rebased a merge conflict, hence the force push. |
rustbot
added
S-waiting-on-review
|
Thanks! Please squash this into a single commit. |
rustbot
added
S-waiting-on-author
noahmbright
force-pushed
the
unix_shims
branch
from
53b4f85
to
55fe3ab
Compare
|
Done - again thanks for your patience and willingness to help. I was definitely too excited about mindlessly changing every |
rustbot
added
S-waiting-on-review
RalfJung
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each instance of
eval_libc("Eis scrubbed out. Currently, this has the idealistic function calls, but this won't compile yet. Marking as a draft and making comments with the representative compilation errors. Whether we want to hold off on making these erring changes or address the root problem now is up to the reviewers.See comments for the issues concretely, but it seems like everything stems from differences between the return types of
this.eval_libcandLibcError.