Use Scalar consistently in foreign item emulation #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
☀️ Test successful - checks-actions |
RalfJung
reviewed
Jul 30, 2024
| let result = this.pthread_cond_broadcast(cond)?; | ||
| this.write_scalar(Scalar::from_i32(result), dest)?; | ||
| this.pthread_cond_broadcast(cond)?; | ||
| this.write_null(dest)?; |
There was a problem hiding this comment.
Isn't it nicer to have the knowledge that these always return null inside pthread_cond_broadcast rather than here?
I feel like ideally, there's as little function-specific knowledge in this file as possible. (In fact ideally we'd have a macro generate the match in perfect uniformity... if someone is motivated enough to write such a macro, one day.)
There was a problem hiding this comment.
I guess this would be resolved by always passing in the dest and handling it inside entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 0 of #3772
This just makes the code consistent. While we could also go for consistency the other way, that would only allow us to use integers in some cases where we use
Scalarright now, becauseScalarcan also hold pointers where applicable.There's also no danger in messing up (even though we do lose some compile-time checks), as
Scalarknows the size of the integer stored within, so it will check that against the destination when it is written. In fact, this makes the checks much stronger compared withwrite_int, which just checks that the integer fits into the destination size.