Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment with macOS M1 runners #3433

Merged
merged 2 commits into from
Mar 31, 2024
Merged

experiment with macOS M1 runners #3433

merged 2 commits into from
Mar 31, 2024

Conversation

RalfJung
Copy link
Member

Try running our macOS CI on the new free M1 runners. This would mean that our 3 jobs run 3 different OSes and 3 different host CPU architectures. :)

@RalfJung
Copy link
Member Author

Hm, that doesn't seem to work -- they don't have cargo?
According to this Ruts is supposed to be installed.

@RalfJung
Copy link
Member Author

Oh so the problem was the cache, interesting. No idea how a bad cache would lead to that kind of error, probably because some binaries have the wrong architecture or so?

And the build was very fast, too.
@rust-lang/miri what do you think, shall we give these runners a try? It's easy to switch back to the old runners if we're getting problems.

@bors
Copy link
Contributor

bors commented Mar 31, 2024

☔ The latest upstream changes (presumably #3436) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member Author

One point I didn't realize is that this is still a tier 2 target. So there's some risk things break as rustc CI doesn't cover everything.

But it's also easy to revert this PR in the future, should it become a problem.

@RalfJung
Copy link
Member Author

Judging from this GH announcement, macos-latest will switch to M1 machines some time soon (April - June). So we have to either do something like this PR or set the runner to macos-12 to get more time to migrate.

@saethlin
Copy link
Member

I do not think the risk is very high. If aarch64 MacOS breaks, too many of us will know because we develop on it. Speed is nice. No objection to merging this.

@RalfJung
Copy link
Member Author

RalfJung commented Mar 31, 2024

I do not think the risk is very high. If aarch64 MacOS breaks, too many of us will know because we develop on it. Speed is nice. No objection to merging this.

Yeah, makes sense. And additionally we can serve as a canary for Rust compiler stuff breaking on M1 hosts, which is a good service to the compiler team. This target is clearly going to become tier 1, so we may as well be part of slowly increasing test coverage.

@bors r+

Cc @shepmaster since you seem to be tracking M1 progress. :)
Cc rust-lang/rust#73908

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit 9e7ff74 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit 9e7ff74 with merge 38ed8a8...

bors added a commit that referenced this pull request Mar 31, 2024
experiment with macOS M1 runners

Try running our macOS CI on the new free M1 runners. This would mean that our 3 jobs run 3 different OSes and 3 different host CPU architectures. :)
looks like the M1 runners don't like it when the cache was created on x86

also reorder the lines to be more semantically grouped
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit a99ed29 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit a99ed29 with merge 5918da6...

@bors
Copy link
Contributor

bors commented Mar 31, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 5918da6 to master...

@bors bors merged commit 5918da6 into rust-lang:master Mar 31, 2024
8 checks passed
@RalfJung RalfJung deleted the m1 branch March 31, 2024 11:36
@shepmaster
Copy link
Member

this is still a tier 2 target

To the best of my knowledge, this is in name only. Right when the M1 runners came out we enabled tests and other things that the tier 1 platforms do. It’s mostly waiting on me to do the paperwork for the promotion and I’m just waiting for a bit of stability on GitHub’s side over a medium-length time period.

switch to M1 machines some time soon (April - June)

I had missed that, so that might be the sign I was waiting for…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants