Skip to content

Commit

Permalink
Rollup merge of #128731 - RalfJung:simd-shuffle-vector, r=workingjubilee
Browse files Browse the repository at this point in the history
simd_shuffle intrinsic: allow argument to be passed as vector

See rust-lang/rust#128738 for context.

I'd like to get rid of [this hack](https://github.com/rust-lang/rust/blob/6c0b89dfac65be9a5be12f938f23098ebc36c635/compiler/rustc_codegen_ssa/src/mir/block.rs#L922-L935). rust-lang/rust#128537 almost lets us do that since constant SIMD vectors will then be passed as immediate arguments. However, simd_shuffle for some reason actually takes an *array* as argument, not a vector, so the hack is still required to ensure that the array becomes an immediate (which then later stages of codegen convert into a vector, as that's what LLVM needs).

This PR prepares simd_shuffle to also support a vector as the `idx` argument. Once this lands, stdarch can hopefully be updated to pass `idx` as a vector, and then support for arrays can be removed, which finally lets us get rid of that hack.
  • Loading branch information
tgross35 authored Aug 27, 2024
2 parents abedc0c + 99823c8 commit 2ec7a70
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 2ec7a70

Please sign in to comment.