Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable f16 for LoongArch64 #722

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Nov 1, 2024

Disable f161 for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures in testcrate/tests/conv.rs. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.

Disable `f161` for LoongArch64 due to incorrect code generation on LLVM 19,
which causes failures in `testcrate/tests/conv.rs`. This workaround will
remain in place until llvm/llvm-project#109093 is merged or we upgrade to
LLVM 20.
@tgross35
Copy link
Contributor

tgross35 commented Nov 1, 2024

Do tests pass if you only disable FFI calls here

if (target.arch == "aarch64" && target.os == "linux")
|| target.arch.starts_with("arm")
|| target.arch == "powerpc"
|| target.arch == "powerpc64"
|| target.arch == "powerpc64le"
|| (target.arch == "x86" && !target.has_feature("sse"))
|| target.os == "windows"
// Linking says "error: function signature mismatch: __extendhfsf2" and seems to
// think the signature is either `(i32) -> f32` or `(f32) -> f32`. See
// <https://github.com/llvm/llvm-project/issues/96438>.
|| target.arch == "wasm32"
|| target.arch == "wasm64"
instead of disabling everything for the type?

@heiher
Copy link
Contributor Author

heiher commented Nov 1, 2024

Do tests pass if you only disable FFI calls here

if (target.arch == "aarch64" && target.os == "linux")
|| target.arch.starts_with("arm")
|| target.arch == "powerpc"
|| target.arch == "powerpc64"
|| target.arch == "powerpc64le"
|| (target.arch == "x86" && !target.has_feature("sse"))
|| target.os == "windows"
// Linking says "error: function signature mismatch: __extendhfsf2" and seems to
// think the signature is either `(i32) -> f32` or `(f32) -> f32`. See
// <https://github.com/llvm/llvm-project/issues/96438>.
|| target.arch == "wasm32"
|| target.arch == "wasm64"

instead of disabling everything for the type?

No, they are still failing.

configure.rs Outdated Show resolved Hide resolved
@tgross35 tgross35 enabled auto-merge (squash) November 1, 2024 09:54
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, I updated the comment but this lgtm

@tgross35 tgross35 merged commit b1459f3 into rust-lang:master Nov 1, 2024
25 checks passed
@heiher heiher deleted the loong64-no-f16 branch November 1, 2024 10:00
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
@tgross35
Copy link
Contributor

tgross35 commented Nov 1, 2024

If you need it in rust-lang/rust, this is released in 0.1.138 https://github.com/rust-lang/compiler-builtins/releases/tag/compiler_builtins-v0.1.138. Will probably be a few days before we can bump to that version since a few builtins updates are already queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants