Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build scripts to report error messages through cargo::error #14743

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 29, 2024

Adds the cargo::error build script directive. It is similar to cargo::warning, but it emits an error message and it also fails the build.

This is a repost of #14435 with the tests updated, a note added to the documentation about using this in a library, and updating the MSRV.

Closes #10159

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
@epage
Copy link
Contributor

epage commented Oct 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2024

📌 Commit 8639d7b has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
@bors
Copy link
Collaborator

bors commented Oct 29, 2024

⌛ Testing commit 8639d7b with merge 4f74477...

@bors
Copy link
Collaborator

bors commented Oct 29, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 4f74477 to master...

@bors bors merged commit 4f74477 into rust-lang:master Oct 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presentation of build script errors is noisy, difficult to understand
5 participants