Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(complete): Include descriptions in zsh #14726

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 24, 2024

What does this PR try to resolve?

See clap-rs/clap#5775 for more details

How should we test and review this PR?

If you're not a zsh user, you may need somthings like this to activate the completion system:

# See https://zsh.sourceforge.io/Doc/Release/Completion-System.html
autoload -Uz compinit
compinit
# and then source completion scripts
source <(CARGO_COMPLETE=zsh target/debug/cargo)

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2024
@weihanglo
Copy link
Member

Works for me. Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2024

📌 Commit 56f008d has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2024
@bors
Copy link
Collaborator

bors commented Oct 24, 2024

⌛ Testing commit 56f008d with merge 1a2df63...

@bors
Copy link
Collaborator

bors commented Oct 24, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 1a2df63 to master...

@bors bors merged commit 1a2df63 into rust-lang:master Oct 24, 2024
24 checks passed
@epage epage deleted the zsh branch October 24, 2024 15:59
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
Update cargo

14 commits in cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5..e75214ea4936d2f2c909a71a1237042cc0e14b07
2024-10-18 13:56:15 +0000 to 2024-10-25 16:34:32 +0000
- refactor(env): remove unnecessary clones (rust-lang/cargo#14730)
- test(install): Verify 2024 edition / resolver=3 doesn't affect resolution (rust-lang/cargo#14724)
- Fix: trace `config` `[env]` table in dep-info. (rust-lang/cargo#14701)
- Added unstable-schema generation for Cargo.toml (rust-lang/cargo#14683)
- fix: add source replacement info when no matching package found (rust-lang/cargo#14715)
- feat(complete): Include descriptions in zsh (rust-lang/cargo#14726)
- refactor(fingerprint): avoid unnecessary fopen calls (rust-lang/cargo#14728)
- docs(resolver): Make room for v3 resolver (rust-lang/cargo#14725)
- test: add fixes in the sat resolver (rust-lang/cargo#14707)
- docs(ci): Don't constrainty latest_deps job by MSRV (rust-lang/cargo#14711)
- refactor: use `Iterator::is_sorted` (rust-lang/cargo#14702)
- refactor(rustfix): minor refactors (rust-lang/cargo#14710)
- chore(deps): update msrv (rust-lang/cargo#14705)
- fix(renovate): Switch matchPackageNames to matchDepNames (rust-lang/cargo#14704)
@rustbot rustbot added this to the 1.84.0 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants