-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest cargo install --git when missing registry package looks like a git* URL #10522
Closed
petr-tik
wants to merge
10
commits into
rust-lang:master
from
petr-tik:n10485_install_from_git_error_message_alternative_impl
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b87ae28
Fix #10485
petr-tik 174c80e
Refactor select_dep_pkg error handling
petr-tik 869973f
Revert "Refactor select_dep_pkg error handling"
petr-tik e045b4f
Merge remote-tracking branch 'upstream/master' into n10485_install_fr…
petr-tik 1c9c53b
Experiment with GitUrl to generate the suggestion
petr-tik ef7ee2c
Fix the tests
petr-tik e018509
Merge remote-tracking branch 'upstream/master' into n10485_install_fr…
petr-tik 283c6e8
Fix the build and update Cargo.lock
petr-tik ddea258
Replace git-url-parse with gix::url::parse
petr-tik f08e95b
Limit the actionable error to install https inputs
petr-tik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't think I've seen cargo strictly follow rustc's error conventions, I think it'd be helpful for us to consider them with our error messages. See https://rustc-dev-guide.rust-lang.org/diagnostics.html#suggestion-style-guide.
While this isn't quite a question, it still falls under the "be more explicit" part of questions where it says
Maybe the "further instruction" section can also provide ideas on how to work this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I will rewrite the error message to follow rustc conventions for the suggestion along the lines of
I think the original first part of the error message is a) good enough b) familiar to users by now, so will only rewrite the suggestion