Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This Development Cycle in Cargo 1.83 #1422

Merged
merged 5 commits into from
Oct 31, 2024
Merged

This Development Cycle in Cargo 1.83 #1422

merged 5 commits into from
Oct 31, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 30, 2024 •
edited by rustbot
Loading

epage and others added 2 commits October 30, 2024 20:40
@epage @weihanglo
fix: Typo
5d43de3 
Co-authored-by: Weihang Lo <[email protected]>
@epage @weihanglo
fix: Typo
87927de 
Co-authored-by: Weihang Lo <[email protected]>
Kriskras99
Kriskras99 reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Kriskras99 Kriskras99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing these, they're very informative!

I found two sentences that didn't seem entirely correct.

posts/inside-rust/2024-10-31-this-development-cycle-in-cargo-1.83.md Outdated Show resolved Hide resolved
posts/inside-rust/2024-10-31-this-development-cycle-in-cargo-1.83.md Outdated Show resolved Hide resolved
epage and others added 2 commits October 31, 2024 08:58
@epage @Kriskras99
fix: Typo
98e4006 
Co-authored-by: Kriskras99 <[email protected]>
@epage @Kriskras99
fix: Typo
8575777 
Co-authored-by: Kriskras99 <[email protected]>
ehuss
ehuss approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit d9e69d4 into rust-lang:master Oct 31, 2024
3 checks passed
@epage epage deleted the 1.83 branch October 31, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kriskras99 Kriskras99 Kriskras99 left review comments

@ehuss ehuss ehuss approved these changes

@weihanglo weihanglo weihanglo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epage @ehuss @Kriskras99 @weihanglo