Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 10-03 #93

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Update 10-03 #93

merged 4 commits into from
Mar 12, 2022

Conversation

swnakamura
Copy link

@swnakamura swnakamura commented Sep 24, 2020 •
edited
Loading

@tatsuya6502 tatsuya6502 marked this pull request as draft September 24, 2020 01:57
This was linked to issues Sep 24, 2020
ライフタイムの解説のサンプルコード実行時に発生するエラーメッセージが説明と異なる #37
Closed
ch10-03のアップデート #86
Closed
@tatsuya6502 tatsuya6502 added this to the 2018 Ed. 02 milestone Sep 24, 2020
@swnakamura swnakamura changed the title [WIP] Update 10-03 Update 10-03 Sep 24, 2020
@swnakamura swnakamura marked this pull request as ready for review September 24, 2020 23:44
@tatsuya6502 tatsuya6502 self-requested a review September 25, 2020 00:46
@tatsuya6502 tatsuya6502 self-assigned this Sep 25, 2020
@tatsuya6502 tatsuya6502 changed the base branch from master-ja to need-review-ja March 7, 2022 14:12
@tatsuya6502 tatsuya6502 mentioned this pull request Mar 8, 2022
Merged
@tatsuya6502 tatsuya6502 deleted the branch rust-lang-ja:master-ja March 12, 2022 02:55
@tatsuya6502 tatsuya6502 reopened this Mar 12, 2022
@tatsuya6502
Copy link
Member

以下のPRとのコンフリクトを解消しました。（コミット）

@tatsuya6502 tatsuya6502 changed the base branch from need-review-ja to master-ja March 12, 2022 06:15
tatsuya6502
tatsuya6502 approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューが遅くなり申しわけありません。マージします。

@tatsuya6502 tatsuya6502 merged commit fea0ef1 into rust-lang-ja:master-ja Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatsuya6502 tatsuya6502 tatsuya6502 approved these changes

Assignees

@tatsuya6502 tatsuya6502

Labels
None yet
Projects
None yet
Milestone
2018 Ed. 02
2 participants
@swnakamura @tatsuya6502