replace uses of ! with Void #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 11, 2018
80: replace uses of ! with Void r=japaric a=japaric We are soon going to push for embedded *library* development on beta (1.27-beta) to minimize the number of unstable features used in the ecosystem and ease the transition towards *application* development on stable (1.28 or 1.29). Unfortunately `!` didn't make it into the beta release but we still need to make this crate work on beta because a lot of crates depend on it. So this PR replaces the single use of the `!` type (cf. `CountDown.wait`) with the equivalent, but stable, `Void` type. This is a [breaking-change]. Implementations of the `CountDown` trait will have to update the signature of `wait` to return `nb::Result<(), Void>`. cc @therealprof @hannobraun I'm going to publish v0.2.0 *soon* (ideally tonight). If there's some **breaking**, but *uncontroversial*, change that should be included in it let me know ASAP so we can land it before the release. Co-authored-by: Jorge Aparicio <[email protected]>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 11, 2018
80: replace uses of ! with Void r=japaric a=japaric We are soon going to push for embedded *library* development on beta (1.27-beta) to minimize the number of unstable features used in the ecosystem and ease the transition towards *application* development on stable (1.28 or 1.29). Unfortunately `!` didn't make it into the beta release but we still need to make this crate work on beta because a lot of crates depend on it. So this PR replaces the single use of the `!` type (cf. `CountDown.wait`) with the equivalent, but stable, `Void` type. This is a [breaking-change]. Implementations of the `CountDown` trait will have to update the signature of `wait` to return `nb::Result<(), Void>`. cc @therealprof @hannobraun I'm going to publish v0.2.0 *soon* (ideally tonight). If there's some **breaking**, but *uncontroversial*, change that should be included in it let me know ASAP so we can land it before the release. Co-authored-by: Jorge Aparicio <[email protected]>
Build succeeded |
|
Meh, this sounds like a lot of unnecessary work for implementers of the hal. How long will it take until |
peckpeck
pushed a commit
to peckpeck/embedded-hal
that referenced
this pull request
Nov 10, 2022
81: Add features for spi and i2c r=eldruin a=zuckschwerdt Adds the features `i2c` and `spi` for an optional dependency on `i2cdev` and `spidev`. Discussion in rust-embedded#80. Closes rust-embedded#80 Co-authored-by: Christian W. Zuckschwerdt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are soon going to push for embedded library development on beta (1.27-beta) to minimize the
number of unstable features used in the ecosystem and ease the transition towards application
development on stable (1.28 or 1.29).
Unfortunately
!didn't make it into the beta release but we still need to make this crate work onbeta because a lot of crates depend on it. So this PR replaces the single use of the
!type (cf.CountDown.wait) with the equivalent, but stable,Voidtype.This is a [breaking-change]. Implementations of the
CountDowntrait will have to update thesignature of
waitto returnnb::Result<(), Void>.cc @therealprof @hannobraun I'm going to publish v0.2.0 soon (ideally tonight). If there's
some breaking, but uncontroversial, change that should be included in it let me know ASAP so
we can land it before the release.