Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the relative link to examples work from the refinery folder #318

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

htmfilho
Copy link
Contributor

@htmfilho htmfilho commented Mar 4, 2024

This README.md file is reused in the refinery folder. From there, the link to the examples folder don't work. I'm proposing to change the link to a relative one, starting from the rust-db profile.

This `README.md` file is reused in the `refinery` folder. From there, the link to the examples don't work. I'm proposing to change the link to a relative one, starting from the `rust-db` profile.
@jxs jxs changed the title Make the relative link to examples work from the refinary folder Make the relative link to examples work from the refinery folder Mar 4, 2024
@jxs
Copy link
Member

jxs commented Mar 4, 2024

Hi, the README.md you are trying to change is the main one, and with your change the link breaks, did you mean to change the one in the refinery dir?

@htmfilho
Copy link
Contributor Author

htmfilho commented Mar 5, 2024

Hi @jxs , the link to the examples is a relative one ('examples'), but the README.md file is rendered in two different places:

  1. https://github.com/rust-db/refinery
  2. https://github.com/rust-db/refinery/tree/main/refinery

breaking this relative link. I see my initial commit didn't solve the problem, but in my last commit, I'm changing the relative link to an absolute one.

Screenshot 2024-03-05 at 10 53 27 AM

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying, LGTM!

@jxs jxs merged commit 7e922af into rust-db:main Mar 5, 2024
29 checks passed
@htmfilho htmfilho deleted the patch-1 branch March 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants