Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for number parsing #1769

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

CXWorks
Copy link

@CXWorks CXWorks commented Jul 18, 2024

Hi,

Thanks for your time & patience to review this PR.

We are researchers focusing on Rust unit tests, we revised our tool for better readability. By examine the existing code, we found several unit tests can be added to improve the repo's overall unit test coverage(this project is already been well tested).

Thanks again for your time.

@CXWorks CXWorks requested a review from Geal as a code owner July 18, 2024 00:03
tests/float.rs Show resolved Hide resolved
epage added a commit to epage/winnow that referenced this pull request Jul 18, 2024
Pulled from rust-bakery/nom#1769

I skipped the float ones because I didn't feel like adapting them to the
`binary` mod.
Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #1769 will degrade performances by 19.3%

Comparing CXWorks:main (d0e2173) with main (561fb6b)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main CXWorks:main Change
number 121.9 ns 151.1 ns -19.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants