Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced ssh with https protocol when cloning the repository #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replaced ssh with https protocol when cloning the repository #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c10dd
Replaced ssh with https protocol when cloning the repository
sudopablosilva Jan 13, 2023
88bb8f5
Complemented the example with finch run
sudopablosilva Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ finch run --rm public.ecr.aws/finch/hello-finch

If you're new to containers, that is so exciting! Give the command above a try after you've installed and initialized Finch. The `run` command pulls an image locally if it's not already present, and then creates and runs a container for you. Note the handy `--rm` option will delete the container instance once it's done executing.

To build an image, try a quick example from the finch client repository.
To build and run a local image, try a quick example from the finch client repository.

```sh
git clone git@github.com:runfinch/finch.git
git clone https://github.com/runfinch/finch.git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to remove the protocol completely and just let it use whatever the user has their git client configured to use.

I've been in some environments where SSH was required due to interference with proxies when using https. I've also been in some environments that would prevent outbound SSH where the configuration needed to be overridden to use https instead.

So basically, the protocol used should be left to the user and not be prescriptive here.

git clone github.com/runfinch/finch

At least that would be my preference.

cd finch/contrib/hello-finch
finch build . -t hello-finch
..
finch run --rm hello-finch
```

Again if you're new to containers, you just built a container image. Nice!
Expand Down