Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fixed-mode-hide-chat #6910

Closed
wants to merge 1 commit into from
Closed

Conversation

deathbeam
Copy link
Member

No description provided.

Signed-off-by: Tomas Slusny <[email protected]>
@runelite-github-app
Copy link

@pajlada
Copy link
Contributor

pajlada commented Oct 30, 2024

This updates the "Hotkey used to toggle hiding the chat" config key name, which will make people lose their configs. You might want to revert that key change back to hideChatHotkey if you're not wanting to have people rebind the hotkey

@YvesW
Copy link
Member

YvesW commented Oct 30, 2024

Is renaming the config key worth it, since it'll be wiping the value?

Additionally, will this consume everyone's escape key by default? Maybe that will cause some support traffic since it's often used to close the bank or to swap tabs. I haven't taken an extensive look at it, so not sure if it does this.

Finally, it's replacing the hide chat option with a toggle. Maybe people will complain that the old behaviour is gone, but that's a decision you have to make yourself.

@deathbeam
Copy link
Member Author

The config rename doesnt matter and it doesnt consume escape key (as it would also need to consume it in the other handlers i guess). But the current behaviour is kinda annoying as it both closes a bank and the chat at once so /shrug

@deathbeam
Copy link
Member Author

Yea I think the new behaviour is too annoying so just gonna revert it.

@deathbeam deathbeam closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants