Edit Equipment-Lock #6899
Open
Edit Equipment-Lock #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Matimatician
commented
Oct 29, 2024
Matimatician
commented
- Added a check to see if user is in LMS, and if so, bypasses the gear checking, to avoid restricting items based on their LMS equivalent.
- Created a collapsible menu for Group ID, to prevent accidental leaking of the information via screenshots / screen sharing.
- Added items required for Tutorial Island to the list of quest exceptions.
update the commit to its most recent case. removed awssdk depency, changed uses of jackson to gson, removed utils and manual hashing to use client.getAccountHash()
changed commit again. changed original file plugin name to be lowercase with dashes to resolve previous build error.
changed to most recent commit removed gson dependency in build.gradle as I've been informed runelite already provides it.
changed name to lowercase with dash
changed original plugin filename back to Equipment_Lock to be consistent with its class, now that I've made this one lowercase with a dash
Added licenses to the 3 main files
Added LICENSE file
Co-authored-by: YvesW <[email protected]>
Game message on consumed equip action now clarifies the plugin causing it with "[Equipment Lock]:" at the start of the message
Added warning about sending data to an external server and switched from log.info to log.debug for most cases
Switched to using slf4j instead of system.err, as well as added the proper dependency for doing so.
Fixed gradle file (again) and added proper annotation for AWSfile for slf4j
Added in OkHttpClient
Fixed an error with RequestBody
Added import java.nio.charset.StandardCharsets;
Attempted bugfix on OkHttpClient
Using log.debug instead of system.out
Added functionality to allow for clue scroll emote items to be excluded
Changed how collapseable menu works in an attempt to bugfix
Changed default config settings for Exclude Clue Scrolls to false. Especially with those hidden in a dropdown, decided that should really be opt-in.
1)Added LMS checking, disabling the checking/blocking of gear during LMS games 2) Added items required for tutorial island to the list of quest exceptions 3) made the group ID a collapsable menu so it can be hidden in screenshots/screen sharing, to prevent accidentally leaking that information.
cleaned up getlocation logic
iProdigy
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.