Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed performance issue, added option to count full potions only #6890

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fixed performance issue, added option to count full potions only #6890

merged 4 commits into from
Oct 29, 2024

Conversation

mrchooch
Copy link
Contributor

No description provided.

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 28, 2024 •
edited
Loading

potion-storage-bars: ecf046933bd47638d8f8361b6072448148231754...7a03a80e8e93bd91635d2c66b2f59dc91c18463e

@iProdigy
Copy link
Member

Is changing the config group intentional? You will effectively be setting everyone on the default config

@mrchooch
Copy link
Contributor Author

Oops, good catch

@iProdigy
Copy link
Member

Could you also remove this unused field https://github.com/mrchooch/potion-bars/blob/dd2197a0b904c95ee46be67715288886865365d4/src/main/java/com/potionbar/PotionBarPlugin.java#L30 (also unnecessary given @Slf4j)

iProdigy
iProdigy previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@iProdigy iProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final nit: could do potionPanels.clear(); on plugin shutDown

@tylerwgrass tylerwgrass merged commit 8905fb9 into runelite:master Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy iProdigy approved these changes

@tylerwgrass tylerwgrass tylerwgrass approved these changes

Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrchooch @iProdigy @tylerwgrass