Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ban-list-export #6867

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Update ban-list-export #6867

merged 4 commits into from
Oct 29, 2024

Conversation

P2GR
Copy link
Contributor

@P2GR P2GR commented Oct 25, 2024

  • added highlighting in cc panel
  • added tooltip in cc panel
  • added warning in game chat
  • added support for bannedby, reason, date through import.

- added highlighting in cc panel
- added tooltip in cc panel
- added warning in game chat
- added support for bannedby, reason, date through import.
@runelite-github-app
Copy link

runelite-github-app bot commented Oct 25, 2024

@iProdigy
Copy link
Member

ban-list-export: plugin uses terminally deprecated APIs:
Do not create fresh OkHttpClients - always @Inject the client's OkHttpClient

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 25, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 27, 2024
@P2GR
Copy link
Contributor Author

P2GR commented Oct 27, 2024

@iProdigy
Can you point me in a direction about the Terminally Deprecated API calls?

@iProdigy
Copy link
Member

@LlemonDuck LlemonDuck merged commit 80c0e17 into runelite:master Oct 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants