Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create boostnotifier #6696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rikbreukers
Copy link

@rikbreukers rikbreukers commented Oct 2, 2024

Boost Notifier is a handy RuneLite plugin designed to keep track of your skill boosts. You can set up customizable level thresholds for different skills, and the plugin will send you alerts — even email notifications

@runelite-github-app
Copy link

@cdfisher
Copy link
Contributor

cdfisher commented Oct 2, 2024

Please don't close PRs and open new ones if there's an issue. Just push commits to the same branch.

Additionally, if I'm reading it correctly, this would store the user's email password in plaintext in their config, which would be a not-insignificant security concern.

@YvesW
Copy link
Member

YvesW commented Oct 2, 2024

Additionally, could you remove your log.info calls, or replace them with log.debug calls? That way we won't have to read logs with a ton of spam in it.

@LlemonDuck
Copy link
Contributor

What possible use case is there for email? It's not real-time, and I don't feel comfortable introducing that form of external communication.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants