Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced text to sql sample rows #17479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

osamadel
Copy link

@osamadel osamadel commented Jan 10, 2025

Add NLSQLRetrieverWithSampleRows and NLSQLTableQueryEngineWithSampleRows to sql_query.py

Description

This is a very minor addition to the sql_query.py module, adding two classes NLSQLRetrieverWithSampleRows and NLSQLTableQueryEngineWithSampleRows which inherit from NLSQLRetriever and BaseSQLTableQueryEngine respectively. This addition is based on the great tutorial by Jerry Liu which then was updated to Workflows in this notebook. The motivation is that, in both the tutorial and the notebook, there is an implementation to add sample rows inside the context to improve the response of the LLM, by giving it a taste of the content of each retrieved table, which makes the SQL more resilient against slight variations in the values to be queried using SQL, for example, which value to use in a "where" clause under a Leave Type column, is it "Business Trip", "BUSINESS", or "TRIP" or who knows?! Giving a sample of the rows inside the context improves the response of the LLM in that regard. The implementation in the tutorial is done using Workflows or QueryPipeline, where most of it (missing only the sample rows) is already implemented in the NLSQLTableQueryEngine class, so why not add the sample rows to it?!

Fixes # Missing adding sample rows to the context in the NLSQLTableQueryEngine class

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant