fix: remove timeout from the underlying network service #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320
When deploying nested workflows, another "system" workflow
NetworkWorkflowis started under the hood to provide a map workflow<-->service. This workflow has no timeout set, defaulting to 10s. But if the overall deployment requires more than 10 seconds to run,NetworkWorkflowwill exit before the deployment can finish, causing #320We should probably review the strategy of
NetworkWorkflow, specially when nested workflows are involved, but for the time being this fix should be good.I didn't find a way to meaningfully unit test this, and a proper e2e test would take >10s so I propose we don't test it.