Unit tests for remote client mq #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdai
changed the title
nerdai
commented
Jun 23, 2024
logan-markewich
approved these changes
Jun 23, 2024
nerdai
commented
Jun 23, 2024
nerdai
commented
Jun 23, 2024
|
|
||
| logger = logging.getLogger(__name__) | ||
| logger.setLevel(logging.DEBUG) | ||
| logging.basicConfig(level=logging.DEBUG) | ||
|
|
||
|
|
||
| class RemoteClientMessageQueue(BaseMessageQueue): | ||
| base_url: str | ||
| base_url: PydanticValidatedUrl |
There was a problem hiding this comment.
@logan-markewich: while still a str type, this has to be a valid http or https url now
There was a problem hiding this comment.
There's a lot of places where I hardcoded http://.... when creating URLs -- TODO: probably need a better pattern for that to account for https
nerdai
added a commit
that referenced
this pull request
Jul 21, 2024
* wip * add register_consumer unit test * add unit test for deregister consumer * dry * change get_consumers in simple to path param * unit test for publish; move up publish_time stats for QueueMessage * update test * mv and rename remote client to message_queues.simple * cr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.