Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "local" source manager #285

Merged
merged 6 commits into from
Oct 4, 2024
Merged

feat: Add "local" source manager #285

merged 6 commits into from
Oct 4, 2024

Conversation

masci
Copy link
Member

@masci masci commented Oct 3, 2024

This PR adds a local source manager that can be used instead of the git source manager for local experiments and demonstration purposes.

It was used to rewrite the README and can be possibly used in the docs as well, see the preview here.

@masci masci marked this pull request as draft October 3, 2024 14:24
@masci masci marked this pull request as ready for review October 3, 2024 15:24
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good!

small nit: A couple of instances of "LLama Deploy" in the README. A quick search and replace to fix would be great.

README.md Outdated Show resolved Hide resolved
name: ./src
# This assumes the file workflow.py contains a variable called `echo_workflow` containing our workflow instance
path: workflow:echo_workflow
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me want llamactl init 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masci masci merged commit dbcbafc into main Oct 4, 2024
7 checks passed
@masci masci deleted the massi/local-source branch October 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants