Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

PrometheusReader implementation #923

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mjimenezp
Copy link

@mjimenezp mjimenezp commented Feb 3, 2024

Description

Have added a loader to retrieve data from Prometheus.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@mjimenezp
Copy link
Author

make format and make lint executed:
image

@mjimenezp
Copy link
Author

The unit test for the reader are passing:
image

The issue is with running all test, the arangoDB, should i try to fix the issue with that set of unit tests?
image

@mjimenezp mjimenezp marked this pull request as ready for review February 3, 2024 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants