Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Opsgenie reader #908

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Opsgenie reader #908

wants to merge 11 commits into from

Conversation

ns-gsa
Copy link

@ns-gsa ns-gsa commented Jan 28, 2024

Description

New Loader for opsgenie list alerts API

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@ns-gsa ns-gsa marked this pull request as ready for review January 28, 2024 21:54
@ns-gsa ns-gsa marked this pull request as draft February 1, 2024 20:27
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ns-gsa ns-gsa marked this pull request as ready for review February 11, 2024 23:10
@ns-gsa
Copy link
Author

ns-gsa commented Feb 13, 2024

@jerryjliu,
I can see that 2 workflows awaiting approval and only those with write access can merge. What's pending to be able to merge this to run_llama:main

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants