-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter out empty chunks in SentenceSplitter #1517
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 764f0fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@parhammmm is attempting to deploy a commit to the LlamaIndex Team on Vercel. A member of the Team first needs to authorize it. |
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/community
@llamaindex/core
@llamaindex/env
@llamaindex/experimental
llamaindex
@llamaindex/node-parser
@llamaindex/readers
@llamaindex/wasm-tools
@llamaindex/workflow
@llamaindex/anthropic
@llamaindex/clip
@llamaindex/deepinfra
@llamaindex/groq
@llamaindex/ollama
@llamaindex/huggingface
@llamaindex/openai
@llamaindex/portkey-ai
@llamaindex/replicate
@llamaindex/vllm
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find the case then splits get empty, could you please add some tests
@himself65 this was the case where it happened https://gist.github.com/parhammmm/c69e37420c92cb85db788454f2a9fe27 It's a bit of an edge case and I found a way to work around it. Will need to find some time to figure out Llamaindex's test suite and then will add it |
No description provided.