rh config handling on login + config commands #1719
+140
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
save-default-ssh-key
branch
from
358910d to
85a3447
Compare
jlewitt1
force-pushed
the
handling-shared-cluster-creds
branch
from
20d6b9f to
cd1893f
Compare
jlewitt1
force-pushed
the
save-default-ssh-key
branch
from
85a3447 to
6a27b3d
Compare
jlewitt1
force-pushed
the
save-default-ssh-key
branch
from
6a27b3d to
c29b9d4
Compare
…nto save-default-ssh-key
jlewitt1
force-pushed
the
handling-shared-cluster-creds
branch
3 times, most recently
from
74507f6 to
bac7432
Compare
jlewitt1
force-pushed
the
save-default-ssh-key
branch
from
bf57425 to
e608ab3
Compare
jlewitt1
changed the title
jlewitt1
force-pushed
the
save-default-ssh-key
branch
3 times, most recently
from
69425e6 to
8c4cb86
Compare
jlewitt1
changed the title
jlewitt1
force-pushed
the
save-default-ssh-key
branch
4 times, most recently
from
1c7c912 to
ab1fb93
Compare
runhouse/rns/defaults.py
Outdated
| @@ -175,26 +173,26 @@ def upload_defaults( | |||
| to_upload.pop("username", None) | |||
| to_upload.pop("secrets", None) | |||
|
|
|||
There was a problem hiding this comment.
is this intentional?
There was a problem hiding this comment.
these fields are handled separately in den and not in the config proper (this isn't a new change fwiw)
…nto save-default-ssh-key # Conflicts: # runhouse/resources/hardware/cluster.py # runhouse/resources/hardware/on_demand_cluster.py
jlewitt1
force-pushed
the
save-default-ssh-key
branch
from
ab1fb93 to
28860bd
Compare
carolineechen
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.