Merge pull request #41 from scolandrea/fix-return-code-commands

Adding return code for commands
run-as-root · Nov 22, 2023 · 013b002 · 013b002
2 parents 7e30176 + 754585d
commit 013b002
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Console/Command/CollectMetricsCommand.php b/src/Console/Command/CollectMetricsCommand.php
@@ -6,6 +6,7 @@
 
 use Magento\Framework\App\Area;
 use Magento\Framework\App\State;
+use Magento\Framework\Console\Cli;
 use Magento\Framework\Exception\LocalizedException;
 use RunAsRoot\PrometheusExporter\Cron\AggregateMetricsCron;
 use Symfony\Component\Console\Command\Command;
@@ -60,5 +61,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } else {
             $this->aggregateMetricsCron->execute();
         }
+
+        return Cli::RETURN_SUCCESS;
     }
 }
diff --git a/src/Console/Command/ListMetricsCommand.php b/src/Console/Command/ListMetricsCommand.php
@@ -7,6 +7,7 @@
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Framework\App\Area;
 use Magento\Framework\App\State;
+use Magento\Framework\Console\Cli;
 use Magento\Framework\Exception\LocalizedException;
 use RunAsRoot\PrometheusExporter\Api\Data\MetricInterface;
 use RunAsRoot\PrometheusExporter\Api\MetricRepositoryInterface;
@@ -58,7 +59,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if ($searchResults->getTotalCount() === 0) {
             $output->writeln('No metrics found');
 
-            return;
+            return Cli::RETURN_SUCCESS;
         }
 
         /** @var MetricInterface[] $metrics */
@@ -72,5 +73,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         $table->render();
+
+        return Cli::RETURN_SUCCESS;
     }
 }