-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avm2: Add AS3 native initializers, abstract class metadata, remove separate super_init method entirely #18673
Merged
adrian17
merged 7 commits into
ruffle-rs:master
from
adrian17:avm2-drop-super-initializer
Nov 19, 2024
Merged
avm2: Add AS3 native initializers, abstract class metadata, remove separate super_init method entirely #18673
adrian17
merged 7 commits into
ruffle-rs:master
from
adrian17:avm2-drop-super-initializer
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only modified the classes that I already needed to touch during the refactor, that's why I didn't notice Worker and MorphShape - but sure :) Will add them to the test too. |
adrian17
force-pushed
the
avm2-drop-super-initializer
branch
5 times, most recently
from
November 19, 2024 19:24
b722c3c
to
49f5ac2
Compare
Lord-McSweeney
approved these changes
Nov 19, 2024
danielhjacobs
added
A-avm2
Area: AVM2 (ActionScript 3)
T-refactor
Type: Refactor / Cleanup
labels
Nov 19, 2024
adrian17
force-pushed
the
avm2-drop-super-initializer
branch
3 times, most recently
from
November 19, 2024 20:21
71b39aa
to
97e8756
Compare
adrian17
force-pushed
the
avm2-drop-super-initializer
branch
from
November 19, 2024 20:37
97e8756
to
5637c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #18358.