render: Update wgpu to 23 #18431
Merged
render: Update wgpu to 23 #18431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
A-rendering
|
I'm hoping to see a little improvement to webgl performance with this! |
torokati44
force-pushed
the
wgpu-23
branch
2 times, most recently
from
37b6ab5
to
71bcdc2
Compare
torokati44
force-pushed
the
wgpu-23
branch
2 times, most recently
from
c0e1b70
to
75bfc32
Compare
|
@adrian17 I saw you made some recommendations for this on Discord - unfortunately I am weeks behind reading a lot of the channels there, and don't really want to skip over anything important - so if you could please copy them over here, or even amend the PR if you have the time, I would be grateful! One suggestion was about not naming the shader stages, right? None at all, or just some? @Dinnerbone I assume you mean this, right: gfx-rs/wgpu#6427 (Just for future reference...) |
torokati44
commented
Oct 31, 2024
Comment on lines
-257
to
+260
| #[allow(unused_mut)] | ||
| let mut backend = None; | ||
| #[cfg(not(any(target_os = "macos", target_os = "ios")))] | ||
| { | ||
| backend = backend.or(report.vulkan).or(report.gl); | ||
| } | ||
| #[cfg(windows)] | ||
| { | ||
| backend = backend.or(report.dx12); | ||
| } | ||
| #[cfg(any(target_os = "macos", target_os = "ios"))] | ||
| { | ||
| backend = backend.or(report.metal); | ||
| } | ||
|
|
||
| if let Some(stats) = backend { | ||
| tracy.plot(BIND_GROUPS, stats.bind_groups.num_allocated as f64); | ||
| tracy.plot(BUFFERS, stats.buffers.num_allocated as f64); | ||
| tracy.plot(TEXTURES, stats.textures.num_allocated as f64); | ||
| tracy.plot(TEXTURE_VIEWS, stats.texture_views.num_allocated as f64); | ||
| } | ||
| tracy.plot(BIND_GROUPS, report.hub.bind_groups.num_allocated as f64); | ||
| tracy.plot(BUFFERS, report.hub.buffers.num_allocated as f64); | ||
| tracy.plot(TEXTURES, report.hub.textures.num_allocated as f64); | ||
| tracy.plot(TEXTURE_VIEWS, report.hub.texture_views.num_allocated as f64); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Bah, GH linking...
Basically:
torokati44
force-pushed
the
wgpu-23
branch
3 times, most recently
from
497613a
to
3a8b6f2
Compare
Dinnerbone
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us drop a whole bunch of (duplicated) dependencies, just look at Cargo.lock!
Currently using egui master.