core: Fix text selection on focus #18320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
kjarosh
force-pushed
the
focus-test-selection
branch
from
f7ba2e6
to
632c1d2
Compare
kjarosh
force-pushed
the
focus-test-selection
branch
2 times, most recently
from
4c56461
to
6e5f818
Compare
Lord-McSweeney
approved these changes
Nov 15, 2024
This test verifies how the focus and text selection behave when focusing the text field programmatically.
This test verifies how the text selection and focus behave when focusing a text field with the keyboard (tab focusing).
This patch fixes the logic behind selecting text when focusing the text field.
This test verifies how the text field and its selection behave when placing a caret with the mouse.
kjarosh
force-pushed
the
focus-test-selection
branch
from
6e5f818
to
03a93c8
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the logic behind selecting text when focusing the text field.
Most importantly, it will fix the issue of text being selected when clicking instead of a caret being placed.