4333 remove inventory items #4607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/controllers/storage_locations_controller.rb # app/models/item.rb # app/services/item_create_service.rb # spec/controllers/donations_controller_spec.rb # spec/models/inventory_item_spec.rb # spec/models/organization_stats_spec.rb # spec/requests/distributions_requests_spec.rb # spec/requests/purchases_requests_spec.rb # spec/requests/storage_locations_requests_spec.rb # spec/services/allocate_kit_inventory_service_spec.rb # spec/services/deallocate_kit_inventory_service_spec.rb # spec/system/distribution_system_spec.rb
# Conflicts: # app/controllers/distributions_controller.rb # spec/rails_helper.rb
awwaiid
reviewed
Oct 13, 2024
Comment on lines
+67
to
+71
| if @change_by.positive? | ||
| KitAllocateEvent.publish(@kit, @storage_location.id, @change_by) | ||
| else | ||
| KitDeallocateEvent.publish(@kit, @storage_location.id, -@change_by) | ||
| end |
| to_storage_location: storage_location.id, | ||
| to_storage_location: storage_location, |
There was a problem hiding this comment.
Interesting. Good looking.
| @@ -207,16 +196,6 @@ def self.csv_export_headers | |||
| ["Name", "Barcodes", "Base Item", "Quantity"] | |||
| end | |||
|
|
|||
| # TODO remove this method once read_events? is true everywhere | |||
| @@ -40,9 +37,6 @@ def items_below_minimum_quantity | |||
| if @inventory | |||
Comment on lines
112
to
113
| <% else %> | ||
| <%= render partial: "inventory_item_row", | ||
| collection: @storage_location.inventory_items.joins(:item).where(items: { active: true }), | ||
| locals: { version_date: params[:version_date] } %> | ||
| <% end %> |
There was a problem hiding this comment.
No longer need the else at all, and maybe don't need to elsif @legacy_inventory block either?
There was a problem hiding this comment.
Heh I fell into that trap. We do need this because it tracks inventory from before event sourcing was introduced.
|
@dorner " It also removes Kit allocation and deallocation." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4333
Description
Definitely do not merge this.
This removes InventoryItems and all associated functionality, with the exception of the records themselves and the basic associations. It also removes Kit allocation and deallocation.
Need to get all tests passing, and then do some exhaustive manual testing afterwards.