Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JavaScript Controllers to javascript Folder, Configure ESLint, and Create rbui-js NPM Package #69

Closed
wants to merge 6 commits into from

Conversation

cirdes
Copy link
Collaborator

@cirdes cirdes commented Jul 27, 2024

This PR includes the following changes:

  1. Move JavaScript Controllers:

    • Inspired by the Stimulus Reflex project, all JavaScript controllers from the phlex_ui_stimulus project have been moved to a new javascript folder. This restructuring enhances developer experience by consolidating Ruby and JavaScript code in a single project. Additionally, it sets the groundwork for creating generators that can eject components with both Ruby and JavaScript code in the future.
  2. ESLint Configuration:

    • Configured the ESLint project to improve the quality of our JavaScript code. This helps maintain consistent coding standards and catch potential issues early in the development process.
  3. Creation of rbui-js NPM Package:

    • Created a new npm package named rbui-js. This package will allow us to publish our JavaScript code and marks the beginning of the transition to the new project name.

@cirdes cirdes changed the title Adding js folder Moving stimulus controllers to Javascript folder Jul 27, 2024
@cirdes cirdes changed the title Moving stimulus controllers to Javascript folder Move JavaScript Controllers to javascript Folder, Configure ESLint, and Create rbui-js NPM Package Jul 27, 2024
@cirdes cirdes requested a review from SethHorsley July 27, 2024 13:17
@cirdes
Copy link
Collaborator Author

cirdes commented Jul 29, 2024

We decided not to have a JavaScript folder and to keep the JS close to RB components, as suggested in this guide.

@cirdes cirdes closed this Jul 29, 2024
@cirdes cirdes deleted the cirdes/add-js-folder branch July 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant