-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Combobox Component #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iseth, I have moved |
We need to make a new RBUI module to start the migration to the new gem name. |
SethHorsley
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! Love the new rbui and js syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new Combobox component to the PhlexUI library. The Combobox component enhances user interaction by allowing them to select from a list of options using filters. This component was inspired by the Shadcn Combobox component and try to adheres to W3C standards for web accessibility.
Features
combobox
andlistbox
to ensure better accessibility.References
The development of this component was guided by several references to ensure best practices and compliance with accessibility standards:
Libraries and Components Consulted
To ensure comprehensive functionality and usability, several existing libraries and components were reviewed:
Screenshots
Additional Notes
The PhlexUI Combobox and the Shadcn Combobox are available to be tested on: https://phlexui-playground.fly.dev/