Ruby UI refactor #179
Merged
Ruby UI refactor #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethHorsley
force-pushed
the
ruby-ui-refactor
branch
from
da78c54
to
b774b28
Compare
pierry01
reviewed
Nov 5, 2024
Comment on lines
+77
to
+78
| # Create the registration name by dasherizing the component name and prefixing with 'ruby_ui--' | ||
| registration_name = "ruby_ui--#{component_name.dasherize}" |
There was a problem hiding this comment.
i think rbui--something should be replaced with ruby-ui--something instead of ruby_ui--something
There was a problem hiding this comment.
@SethHorsley , I do agree with @pierry01 here. It will be violating stimulus conventions.
There was a problem hiding this comment.
Yes good catch. I can fix it in another pr.
stephannv
approved these changes
Nov 6, 2024
cirdes
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the refactor to
ruby-ui