Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tailwind_merge from generator #164

Closed
wants to merge 1 commit into from

Conversation

stephannv
Copy link
Contributor

Removing bundle add tailwind_merge from install command since tailwind_merge is already a dependency from rbui.

Removing `bundle add tailwind_merge` from install command since tailwind_merge is already a dependency from rbui.

Signed-off-by: stephann <[email protected]>
@cirdes
Copy link
Collaborator

cirdes commented Oct 18, 2024

@stephannv, there's a catch to that.

We want RbUI to also be used with the gem added only in the development environment. The gem would function like the ShadCn CLI, allowing us to generate or eject the components we need, as needed.

Maybe we should adjust the generator to only add tailwind_merge in that scenario.

Going even further, that should be the recommended way of using the gem.

What are your thoughts, @SethHorsley?

@stephannv
Copy link
Contributor Author

Nice. I think is a nice idea to allow devs to extract components to their apps, but IMO (as a new user), I would prefer to not handle all the needed boilerplate to achieve this (I ran rbui install and I got ~45 file changes and a bloated vendor/javascript folder). I would prefer all the freedom of customizing design/behavior of components but without the burden of handling low-level stuff, so I think a mix of two approaches would be great: rbui provides the base structure and we can extract things to our apps (like devise allowing to override controllers, views, callbacks, etc)

@SethHorsley
Copy link
Collaborator

@stephannv I agree. If you're using import maps that bloat in the vendor/js is needed for the gem to work properly right now. But it should not be doing that if you're not using import maps. I like the idea of when removing the gem you have to install tailwind merge manually.

@cirdes cirdes closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants