Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support phlex 2.0 and bump gem 🔨 #153

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,16 @@ jobs:
name: StandardRB Check Action
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec standardrb --format progress
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec standardrb --format progress
tests:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
ruby-version:
- "3.2"
- "3.3"
- "head"
fail-fast: false
matrix:
os: ["ubuntu-latest"]
name: Running minitest
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 0 additions & 1 deletion .ruby-version

This file was deleted.

2 changes: 2 additions & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ruby 3.3.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really want to change from .ruby-version to .tool-verisons?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think so. most tools are supporting it now:
image
https://mise.jdx.dev/configuration.html#tool-versions

it makes it easier to change versions for everything and just in case we forget to update the .ruby-version


6 changes: 3 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: .
specs:
rbui (1.0.0.pre.alpha.3)
phlex (~> 1.10)
rbui (1.0.0.pre.alpha.4)
phlex (~> 2.0.0.beta2)
rouge (~> 4.2.0)
tailwind_merge (>= 0.12)

Expand All @@ -19,7 +19,7 @@ GEM
parser (3.3.3.0)
ast (~> 2.4.1)
racc
phlex (1.11.0)
phlex (2.0.0.beta2)
racc (1.8.0)
rainbow (3.1.1)
rake (13.2.1)
Expand Down
2 changes: 1 addition & 1 deletion lib/rbui/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module RBUI
VERSION = "1.0.0-alpha.3"
VERSION = "1.0.0-alpha.4"
end
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rbui-js",
"version": "1.0.0-alpha.3",
"version": "1.0.0-alpha.4",
"main": "lib/rbui/index.js",
"description": "Stimulus controllers for RbUI Component Library",
"homepage": "https://rbui.dev",
Expand Down
4 changes: 2 additions & 2 deletions rbui.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ Gem::Specification.new do |s|
"https://rubygems.org/gems/rbui"
s.license = "MIT"

s.required_ruby_version = ">= 3.2"
s.required_ruby_version = ">= 3.3"

s.add_dependency "phlex", "~> 1.10"
SethHorsley marked this conversation as resolved.
Show resolved Hide resolved
s.add_dependency "phlex", "~> 2.0.0.beta2"
s.add_dependency "rouge", "~> 4.2.0"
s.add_dependency "tailwind_merge", ">= 0.12"

Expand Down
Loading