Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes the popover component #148

Merged
merged 1 commit into from
Oct 5, 2024
Merged

This fixes the popover component #148

merged 1 commit into from
Oct 5, 2024

Conversation

SethHorsley
Copy link
Collaborator

@SethHorsley SethHorsley commented Oct 3, 2024 •
edited
Loading

popover-ok

pierry01
pierry01 reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@pierry01 pierry01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a dense code to review with 100% sure of success.
I'll test your branch locally and approve, if there isn't bugs

pierry01

This comment was marked as resolved.

Sign in to view

pierry01

This comment was marked as resolved.

Sign in to view

pierry01
pierry01 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@pierry01 pierry01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, ignore the previous revision!
I forgot to run YARN after the RBUI changes...
After the new tests, the Popover is 100% functional
popover-ok

@SethHorsley
Copy link
Collaborator Author

Thanks for adding the gif. I should have added that in the description.

@SethHorsley SethHorsley merged commit 2d7f30e into main Oct 5, 2024
4 checks passed
@SethHorsley SethHorsley deleted the fix-popover branch October 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierry01 pierry01 pierry01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethHorsley @pierry01