Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor js registration and generator implementation #140

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

SethHorsley
Copy link
Collaborator

@SethHorsley SethHorsley commented Sep 23, 2024

Update the RBUI js integration in Rails

This PR changes the js integration of RBUI (Ruby UI) into a Rails application

Details

1. Update app/javascript/application.js

Added the following import to integrate RBUI components:

import "../components/rbui";

2. Create or update app/components/rbui/index.js

Added the following import to integrate RBUI components:

import { application } from "../../../app/javascript/controllers/application";

// Import all controller files
// import ComboboxController from "./combobox/combobox_controller";

// Register all controllers
// application.register("rbui--combobox", ComboboxController);

import RBUI from "rbui-js";
RBUI.initialize(application);

@marcoroth helped with this implementation

Copy link
Collaborator Author

@SethHorsley SethHorsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a double check review

@SethHorsley SethHorsley merged commit abb3ec1 into main Sep 23, 2024
4 checks passed
@SethHorsley SethHorsley deleted the refactor-js branch September 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant