Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD Textarea #139

Merged
merged 2 commits into from
Sep 25, 2024
Merged

ADD Textarea #139

merged 2 commits into from
Sep 25, 2024

Conversation

pierry01
Copy link
Contributor

@pierry01 pierry01 commented Sep 19, 2024 •
edited
Loading

@pierry01 pierry01 marked this pull request as ready for review September 19, 2024 19:31
@SethHorsley
Copy link
Collaborator

this is great! lets get the associated component in the docs repo to merge this in.
https://github.com/rbui-labs/PhlexUI-web/

@pierry01 pierry01 mentioned this pull request Sep 23, 2024
Merged
pierry01
pierry01 commented Sep 23, 2024
View reviewed changes
lib/rbui/textarea/textarea.rb

module RBUI
class Textarea < Base
def initialize(rows: 4, **attrs)
Copy link
Contributor Author

@pierry01 pierry01 Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to 4 because shadcn uses it as default value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pierry01
Copy link
Contributor Author

lets get the associated component in the docs repo to merge this

DONE!

@SethHorsley SethHorsley merged commit 9428238 into ruby-ui:main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierry01 @SethHorsley