Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REMOVE default_attributes FROM TypographyP #137

Closed
wants to merge 3 commits into from

Conversation

pierry01
Copy link
Contributor

@pierry01 pierry01 commented Sep 17, 2024

BEFORE
image

AFTER
image

THE CODE

Tooltip(placement: "bottom") do
  TooltipTrigger do
    plain(helpers.lucide_icon("message-circle", class: "w-4 h-4 text-primary flex-none"))
  end

  TooltipContent(class: "flex flex-col gap-2 w-80 p-2") do
    TypographyP(weight: :medium) { "Comentário" }
    TypographyP { @supplier.approval_justification }

    div(class: "flex flex-row items-center gap-2") do
      plain(helpers.lucide_icon("user", size: 20, class: "text-slate-700"))
      TypographyP { @supplier.approval_user_email }
    end
  end
end

Signed-off-by: Jean Pierry de Souza Mendonça <[email protected]>
Signed-off-by: Jean Pierry de Souza Mendonça <[email protected]>
Signed-off-by: Jean Pierry de Souza Mendonça <[email protected]>
@pierry01 pierry01 changed the title REMOVE [&:not(:first-child)]:mt-6 FROM TypographyP REMOVE default_attributes FROM TypographyP Sep 17, 2024
@pierry01 pierry01 marked this pull request as ready for review September 17, 2024 20:27
@cirdes
Copy link
Collaborator

cirdes commented Sep 17, 2024

@pierry01 ,

This is exactly the same code shadcn has:

export function TypographyP() {
  return (
    <p className="leading-7 [&:not(:first-child)]:mt-6">
      The king, seeing how much happier his subjects were, realized the error of
      his ways and repealed the joke tax.
    </p>
  )
}

https://ui.shadcn.com/docs/components/typography#p

@pierry01
Copy link
Contributor Author

@pierry01 ,

This is exactly the same code shadcn has:

export function TypographyP() {
  return (
    <p className="leading-7 [&:not(:first-child)]:mt-6">
      The king, seeing how much happier his subjects were, realized the error of
      his ways and repealed the joke tax.
    </p>
  )
}

https://ui.shadcn.com/docs/components/typography#p

I have opened an issue in shadcn-ui to FIX that
shadcn-ui/ui#4889

@pierry01 pierry01 closed this Sep 19, 2024
@pierry01 pierry01 deleted the patch-1 branch September 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants