Boxer for secret sharedkey #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Boxes a series of messages between sender's secret key and a receiver's public key using automatically generated nonces. | ||
| * The sequential part of nonces is even if the sender's public key is lexicographically smaller than the receiver's public key, and uneven (odd, not divisible by 2) otherwise. | ||
| * The sequential part of nonces is even if the sender's public key is lexicographically smaller than the receiver's public key, and uneven otherwise. |
There was a problem hiding this comment.
The clarification of the word uneven went missing here.
|
@rubendv thanks for wording corrections, will apply them soon. About the TODO, it's for an issue we found, we're not yet fixing it and our code still does same mistake for now - #14 There is one important thing wrong in this PR we made: it does not make too much sense for unboxer to have default value of nonce_constant (the random nonce). |
|
Okay, I'll wait for you to fix the default value and then it can be merged. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxer/unboxer can now work with a secret preshared key, instead of my privkey + his pubkey.
Done as other constructor.
Needed to move stuff to a base class so it's nicer, but it should be 0-overhead (base class doesn't have vtable).