Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old listings #2064

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: old listings #2064

merged 1 commit into from
Aug 20, 2024

Conversation

MagnusHafstad
Copy link
Contributor

Motivation

  • If someone found an old listing, for example by googleling "indøk infi" they might get an old listing. It was hard to tell that it was old and so some people applied to old listings.

###Fix

  • Disabled apply button if deadline had passe and added a tooltip to nudge people to take a look at deadline

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
indok-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 10:58am

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (35f7a65) to head (6c4689e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2064   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         100      100           
  Lines        3572     3572           
=======================================
  Hits         2975     2975           
  Misses        597      597           
Flag Coverage Δ
apitests 83.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Aug 20, 2024



Test summary

2 0 0 0


Run details

Project Indøk Web
Status Passed
Commit 48886df ℹ️
Started Aug 20, 2024 11:11 AM
Ended Aug 20, 2024 11:12 AM
Duration 01:31 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@MagnusHafstad MagnusHafstad merged commit b1f248c into main Aug 20, 2024
21 checks passed
@MagnusHafstad MagnusHafstad deleted the fix-old-listingsa branch August 20, 2024 11:26
Copy link

cypress bot commented Aug 20, 2024



Test summary

2 0 0 0


Run details

Project Indøk Web
Status Passed
Commit b1f248c
Started Aug 20, 2024 11:39 AM
Ended Aug 20, 2024 11:41 AM
Duration 01:41 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant